Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): use TS interfaces only for public api #499

Merged
merged 1 commit into from
Jul 19, 2022
Merged

fix(types): use TS interfaces only for public api #499

merged 1 commit into from
Jul 19, 2022
+29 −71

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jul 19, 2022

following pmndrs/zustand#1106

It turns out, we don't have public interface 😓 .

This sort of reverts/revisits #474 and #493.

@vercel
Copy link

vercel bot commented Jul 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
valtio ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 1:54AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 918fc45:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration

@github-actions
Copy link

Size Change: 0 B

Total Size: 48.3 kB

ℹ️ View Unchanged
Filename Size
dist/esm/index.js 712 B
dist/esm/macro.js 613 B
dist/esm/macro/vite.js 697 B
dist/esm/utils.js 3.94 kB
dist/esm/vanilla.js 1.9 kB
dist/index.js 880 B
dist/macro.js 910 B
dist/macro/vite.js 982 B
dist/system/index.development.js 871 B
dist/system/index.production.js 508 B
dist/system/macro.development.js 721 B
dist/system/macro.production.js 555 B
dist/system/macro/vite.development.js 828 B
dist/system/macro/vite.production.js 653 B
dist/system/utils.development.js 4.15 kB
dist/system/utils.production.js 2.83 kB
dist/system/vanilla.development.js 2 kB
dist/system/vanilla.production.js 1.25 kB
dist/umd/index.development.js 1 kB
dist/umd/index.production.js 670 B
dist/umd/macro.development.js 1.06 kB
dist/umd/macro.production.js 766 B
dist/umd/macro/vite.development.js 1.15 kB
dist/umd/macro/vite.production.js 874 B
dist/umd/utils.development.js 4.73 kB
dist/umd/utils.production.js 3.02 kB
dist/umd/vanilla.development.js 2.11 kB
dist/umd/vanilla.production.js 1.32 kB
dist/utils.js 4.58 kB
dist/vanilla.js 2.01 kB

compressed-size-action

@dai-shi dai-shi merged commit f09d6c8 into main Jul 19, 2022
@dai-shi dai-shi deleted the fix/types/interfaces-only-for-public-api branch July 19, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dai-shi